leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

atlantic: Increase delay for fw transactions

Browse Source 
The max waiting period (of 1 ms) while reading the data from FW shared
buffer is too small for certain types of data (e.g., stats). There's a
chance that FW could be updating buffer at the same time and driver
would be unsuccessful in reading data. Firmware manual recommends to
have 1 sec timeout to fix this issue.

Fixes: 5cfd54d7dc ("net: atlantic: minimal A2 fw_ops")
Signed-off-by: Dmitry Bogdanov <dbezrukov@marvell.com>
Signed-off-by: Sudarsana Reddy Kalluru <skalluru@marvell.com>
Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Dmitry Bogdanov 2021-11-29 05:28:23 -08:00 committed by David S. Miller
parent 2191b1dfef
commit aa1dcb5646
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2_utils_fw.c
View File

@ -84,7 +84,7 @@ static int hw_atl2_shared_buffer_read_block(struct aq_hw_s *self,
if (cnt > AQ_A2_FW_READ_TRY_MAX) if (cnt > AQ_A2_FW_READ_TRY_MAX)
return -ETIME; return -ETIME;
if (tid1.transaction_cnt_a != tid1.transaction_cnt_b) if (tid1.transaction_cnt_a != tid1.transaction_cnt_b)
udelay(1); mdelay(1);
} while (tid1.transaction_cnt_a != tid1.transaction_cnt_b); } while (tid1.transaction_cnt_a != tid1.transaction_cnt_b);
hw_atl2_mif_shared_buf_read(self, offset, (u32 *)data, dwords); hw_atl2_mif_shared_buf_read(self, offset, (u32 *)data, dwords);
@ -339,8 +339,11 @@ static int aq_a2_fw_update_stats(struct aq_hw_s *self)
{ {
struct hw_atl2_priv *priv = (struct hw_atl2_priv *)self->priv; struct hw_atl2_priv *priv = (struct hw_atl2_priv *)self->priv;
struct statistics_s stats; struct statistics_s stats;
int err;
hw_atl2_shared_buffer_read_safe(self, stats, &stats); err = hw_atl2_shared_buffer_read_safe(self, stats, &stats);
if (err)
return err;
#define AQ_SDELTA(_N_, _F_) (self->curr_stats._N_ += \ #define AQ_SDELTA(_N_, _F_) (self->curr_stats._N_ += \
stats.msm._F_ - priv->last_stats.msm._F_) stats.msm._F_ - priv->last_stats.msm._F_)