leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ext4: fix memory leak in ext4_mb_init_backend on error path.

Browse Source 
Fix a memory leak discovered by syzbot when a file system is corrupted
with an illegally large s_log_groups_per_flex.

Reported-by: syzbot+aa12d6106ea4ca1b6aae@syzkaller.appspotmail.com
Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
Cc: stable@kernel.org
Link: https://lore.kernel.org/r/20210412073837.1686-1-phil@philpotter.co.uk
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
This commit is contained in:
Phillip Potter 2021-04-12 08:38:37 +01:00 committed by Theodore Ts'o
parent 6c09127396
commit a8867f4e38
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/ext4/mballoc.c
View File

@ -3217,7 +3217,7 @@ static int ext4_mb_init_backend(struct super_block *sb)
*/ */
if (sbi->s_es->s_log_groups_per_flex >= 32) { if (sbi->s_es->s_log_groups_per_flex >= 32) {
ext4_msg(sb, KERN_ERR, "too many log groups per flexible block group"); ext4_msg(sb, KERN_ERR, "too many log groups per flexible block group");
goto err_freesgi; goto err_freebuddy;
} }
sbi->s_mb_prefetch = min_t(uint, 1 << sbi->s_es->s_log_groups_per_flex, sbi->s_mb_prefetch = min_t(uint, 1 << sbi->s_es->s_log_groups_per_flex,
BLK_MAX_SEGMENT_SIZE >> (sb->s_blocksize_bits - 9)); BLK_MAX_SEGMENT_SIZE >> (sb->s_blocksize_bits - 9));