leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

virtgpu: remove redundant task_comm copying

Browse Source 
Remove redundant task name copying because:

1. task->comm is already NUL-terminated
2. virtio_gpu_context_create() trims passed dbgname anyway

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Link: http://patchwork.freedesktop.org/patch/msgid/588612bbc672e8b598e10f79fcbc041122e844ba.1504202471.git.mirq-linux@rere.qmqm.pl
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
This commit is contained in:
Michał Mirosław 2017-08-31 20:06:12 +02:00 committed by Gerd Hoffmann
parent 4013e44ffa
commit a86f25518e
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/gpu/drm/virtio/virtgpu_kms.c
View File

@ -272,20 +272,18 @@ int virtio_gpu_driver_open(struct drm_device *dev, struct drm_file *file)
struct virtio_gpu_device *vgdev = dev->dev_private; struct virtio_gpu_device *vgdev = dev->dev_private;
struct virtio_gpu_fpriv *vfpriv; struct virtio_gpu_fpriv *vfpriv;
uint32_t id; uint32_t id;
char dbgname[64], tmpname[TASK_COMM_LEN]; char dbgname[TASK_COMM_LEN];
/* can't create contexts without 3d renderer */ /* can't create contexts without 3d renderer */
if (!vgdev->has_virgl_3d) if (!vgdev->has_virgl_3d)
return 0; return 0;
get_task_comm(tmpname, current);
snprintf(dbgname, sizeof(dbgname), "%s", tmpname);
dbgname[63] = 0;
/* allocate a virt GPU context for this opener */ /* allocate a virt GPU context for this opener */
vfpriv = kzalloc(sizeof(*vfpriv), GFP_KERNEL); vfpriv = kzalloc(sizeof(*vfpriv), GFP_KERNEL);
if (!vfpriv) if (!vfpriv)
return -ENOMEM; return -ENOMEM;
get_task_comm(dbgname, current);
virtio_gpu_context_create(vgdev, strlen(dbgname), dbgname, &id); virtio_gpu_context_create(vgdev, strlen(dbgname), dbgname, &id);
vfpriv->ctx_id = id; vfpriv->ctx_id = id;