leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IB/core: Fix static analysis warning in ib_policy_change_task

Browse Source 
ib_get_cached_subnet_prefix can technically fail, but the only way it
could is not possible based on the loop conditions. Check the return
value before using the variable sp to resolve a static analysis warning.

-v1:
- Fix check to !ret. Paul Moore

Fixes: 8f408ab64b ("selinux lsm IB/core: Implement LSM notification
system")
Signed-off-by: Daniel Jurgens <danielj@mellanox.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: James Morris <james.l.morris@oracle.com>
This commit is contained in:
Daniel Jurgens 2017-07-05 16:15:21 +03:00 committed by James Morris
parent 79d0636ac7
commit a750cfde13
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/infiniband/core/device.c
View File

@ -376,7 +376,8 @@ static void ib_policy_change_task(struct work_struct *work)
WARN_ONCE(ret, WARN_ONCE(ret,
"ib_get_cached_subnet_prefix err: %d, this should never happen here\n", "ib_get_cached_subnet_prefix err: %d, this should never happen here\n",
ret); ret);
ib_security_cache_change(dev, i, sp); if (!ret)
ib_security_cache_change(dev, i, sp);
} }
} }
up_read(&lists_rwsem); up_read(&lists_rwsem);