forked from Minki/linux
ext4: fix code documentatioon
Add a TODO to remember fixing REQ_FUA | REQ_PREFLUSH for fast commit buffers. Also, fix a typo in top level comment in fast_commit.c Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com> Link: https://lore.kernel.org/r/20201106035911.1942128-15-harshadshirwadkar@gmail.com Signed-off-by: Theodore Ts'o <tytso@mit.edu>
This commit is contained in:
parent
f6634e2609
commit
a740762fb3
@ -83,7 +83,7 @@
|
||||
*
|
||||
* Atomicity of commits
|
||||
* --------------------
|
||||
* In order to gaurantee atomicity during the commit operation, fast commit
|
||||
* In order to guarantee atomicity during the commit operation, fast commit
|
||||
* uses "EXT4_FC_TAG_TAIL" tag that marks a fast commit as complete. Tail
|
||||
* tag contains CRC of the contents and TID of the transaction after which
|
||||
* this fast commit should be applied. Recovery code replays fast commit
|
||||
@ -542,6 +542,7 @@ static void ext4_fc_submit_bh(struct super_block *sb)
|
||||
int write_flags = REQ_SYNC;
|
||||
struct buffer_head *bh = EXT4_SB(sb)->s_fc_bh;
|
||||
|
||||
/* TODO: REQ_FUA | REQ_PREFLUSH is unnecessarily expensive. */
|
||||
if (test_opt(sb, BARRIER))
|
||||
write_flags |= REQ_FUA | REQ_PREFLUSH;
|
||||
lock_buffer(bh);
|
||||
|
Loading…
Reference in New Issue
Block a user