leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mfd: twl-core: Return directly after a failed platform_device_alloc() in add_numbered_child()

Browse Source 
The platform_device_put() function was called in one case by the
add_numbered_child() function during error handling even if the passed
variable "pdev" contained a null pointer.
Return directly in this case.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
This commit is contained in:
Markus Elfring 2016-06-26 12:25:36 +02:00 committed by Lee Jones
parent d347792c31
commit a67911d38f
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/mfd/twl-core.c
View File

@ -622,11 +622,8 @@ add_numbered_child(unsigned mod_no, const char *name, int num,
twl = &twl_priv->twl_modules[sid]; twl = &twl_priv->twl_modules[sid];
pdev = platform_device_alloc(name, num); pdev = platform_device_alloc(name, num);
if (!pdev) { if (!pdev)
dev_dbg(&twl->client->dev, "can't alloc dev\n"); return ERR_PTR(-ENOMEM);
status = -ENOMEM;
goto err;
}
pdev->dev.parent = &twl->client->dev; pdev->dev.parent = &twl->client->dev;