forked from Minki/linux
staging: slicoss: remove extra parentheses around right bit shift operations
Removes extra parentheses around bitwise right shift operations. The cases handled here are when resultant values are assigned to variables. The issue was detected and resolved using the following coccinelle script: @@ expression e, e1; constant c; @@ e = -(e1 +e1 >> -c); +c; @@ identifier i; constant c; type t; expression e; @@ t i = -(e +e >> -c); +c; @@ expression e, e1; identifier f; constant c; @@ e1 = f(..., -(e +e >> -c) +c ,...); Some coding style issues were handled manually to avoid checkpatch warnings and errors. Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
e1bc88f1d9
commit
a659b3e807
@ -164,7 +164,7 @@ static void slic_mcast_set_bit(struct adapter *adapter, char *address)
|
||||
/* Get the CRC polynomial for the mac address */
|
||||
/* we use bits 1-8 (lsb), bitwise reversed,
|
||||
* msb (= lsb bit 0 before bitrev) is automatically discarded */
|
||||
crcpoly = (ether_crc(ETH_ALEN, address)>>23);
|
||||
crcpoly = ether_crc(ETH_ALEN, address)>>23;
|
||||
|
||||
/* We only have space on the SLIC for 64 entries. Lop
|
||||
* off the top two bits. (2^6 = 64)
|
||||
@ -1862,8 +1862,8 @@ static void slic_xmit_build_request(struct adapter *adapter,
|
||||
hcmd->cmdsize = (u32) ((((u64)&ihcmd->u.slic_buffers.bufs[1] -
|
||||
(u64) hcmd) + 31) >> 5);
|
||||
#else
|
||||
hcmd->cmdsize = ((((u32) &ihcmd->u.slic_buffers.bufs[1] -
|
||||
(u32) hcmd) + 31) >> 5);
|
||||
hcmd->cmdsize = (((u32)&ihcmd->u.slic_buffers.bufs[1] -
|
||||
(u32)hcmd) + 31) >> 5;
|
||||
#endif
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user