leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

module: be more picky about allowing missing module versions

Browse Source 
We allow missing __versions sections, because modprobe --force strips
it.  It makes less sense to allow sections where there's no version
for a specific symbol the module uses, so disallow that.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Rusty Russell 2008-05-09 16:24:21 +10:00 committed by Linus Torvalds
parent 6c2545eeff
commit a5dd697074
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
kernel/module.c
View File

@ -917,6 +917,10 @@ static int check_version(Elf_Shdr *sechdrs,
if (!crc) if (!crc)
return 1; return 1;
/* No versions at all? modprobe --force does this. */
if (versindex == 0)
return try_to_force_load(mod, symname) == 0;
versions = (void *) sechdrs[versindex].sh_addr; versions = (void *) sechdrs[versindex].sh_addr;
num_versions = sechdrs[versindex].sh_size num_versions = sechdrs[versindex].sh_size
/ sizeof(struct modversion_info); / sizeof(struct modversion_info);
@ -932,8 +936,9 @@ static int check_version(Elf_Shdr *sechdrs,
goto bad_version; goto bad_version;
} }
if (!try_to_force_load(mod, symname)) printk(KERN_WARNING "%s: no symbol version for %s\n",
return 1; mod->name, symname);
return 0;
bad_version: bad_version:
printk("%s: disagrees about version of symbol %s\n", printk("%s: disagrees about version of symbol %s\n",