leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drm/amd/display: Only flush delta from last command execution

Browse Source 
[Why]
We're currently flushing commands that had been previously been
flushed or are currently being processed by the DMCUB when we don't
immediately wait for idle after command execution.

[How]
Avoiding reflushing the data by keeping track of the last wptr.

We'll treat this as the actual rptr by creating a copy of the inbox
and modifying the copy's rptr.

Reviewed-by: Eric Yang <Eric.Yang2@amd.com>
Acked-by: Wayne Lin <wayne.lin@amd.com>
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
Nicholas Kazlauskas 2021-11-02 14:27:30 -04:00 committed by Alex Deucher
parent c09bb36dd1
commit a53b554b56
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/gpu/drm/amd/display/dmub/dmub_srv.h
View File

@ -411,6 +411,7 @@ struct dmub_srv {
struct dmub_srv_base_funcs funcs; struct dmub_srv_base_funcs funcs;
struct dmub_srv_hw_funcs hw_funcs; struct dmub_srv_hw_funcs hw_funcs;
struct dmub_rb inbox1_rb; struct dmub_rb inbox1_rb;
uint32_t inbox1_last_wptr;
/** /**
* outbox1_rb is accessed without locks (dal & dc) * outbox1_rb is accessed without locks (dal & dc)
* and to be used only in dmub_srv_stat_get_notification() * and to be used only in dmub_srv_stat_get_notification()

9
drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c
View File

@ -609,6 +609,8 @@ enum dmub_status dmub_srv_cmd_queue(struct dmub_srv *dmub,
enum dmub_status dmub_srv_cmd_execute(struct dmub_srv *dmub) enum dmub_status dmub_srv_cmd_execute(struct dmub_srv *dmub)
{ {
struct dmub_rb flush_rb;
if (!dmub->hw_init) if (!dmub->hw_init)
return DMUB_STATUS_INVALID; return DMUB_STATUS_INVALID;
@ -617,9 +619,14 @@ enum dmub_status dmub_srv_cmd_execute(struct dmub_srv *dmub)
* been flushed to framebuffer memory. Otherwise DMCUB might * been flushed to framebuffer memory. Otherwise DMCUB might
* read back stale, fully invalid or partially invalid data. * read back stale, fully invalid or partially invalid data.
*/ */
dmub_rb_flush_pending(&dmub->inbox1_rb); flush_rb = dmub->inbox1_rb;
flush_rb.rptr = dmub->inbox1_last_wptr;
dmub_rb_flush_pending(&flush_rb);
dmub->hw_funcs.set_inbox1_wptr(dmub, dmub->inbox1_rb.wrpt); dmub->hw_funcs.set_inbox1_wptr(dmub, dmub->inbox1_rb.wrpt);
dmub->inbox1_last_wptr = dmub->inbox1_rb.wrpt;
return DMUB_STATUS_OK; return DMUB_STATUS_OK;
} }