leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pinctrl: cy8c95x0: Remove useless conditionals

Browse Source 
The pin control framework checks pin boundaries before calling
the respective driver's callbacks. Hence no need to check for
pin boundaries, the respective conditionals won't be ever true.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Link: https://lore.kernel.org/r/20220902182650.83098-9-andriy.shevchenko@linux.intel.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Andy Shevchenko 2022-09-02 21:26:42 +03:00 committed by Linus Walleij
parent 44c2533366
commit a416bfb7d5
1 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/pinctrl/pinctrl-cy8c95x0.c
View File

@ -1040,14 +1040,6 @@ static int cy8c95x0_pinctrl_get_group_pins(struct pinctrl_dev *pctldev,
const unsigned int **pins,
unsigned int *num_pins)
{
struct cy8c95x0_pinctrl *chip = pinctrl_dev_get_drvdata(pctldev);
if (group >= chip->tpin) {
*pins = NULL;
*num_pins = 0;
return 0;
}
*pins = &cy8c9560_pins[group].number;
*num_pins = 1;
return 0;
@ -1115,9 +1107,6 @@ static int cy8c95x0_set_mux(struct pinctrl_dev *pctldev, unsigned int selector,
{
struct cy8c95x0_pinctrl *chip = pinctrl_dev_get_drvdata(pctldev);
if (group >= chip->tpin)
return -EINVAL;
return cy8c95x0_pinmux_cfg(chip, selector, group);
}
@ -1144,9 +1133,6 @@ static int cy8c95x0_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
int ret = 0;
int i;
if (WARN_ON(pin >= chip->tpin))
return -EINVAL;
for (i = 0; i < num_configs; i++) {
ret = cy8c95x0_gpio_set_pincfg(chip, pin, configs[i]);
if (ret)