leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

x86: fix ioremap pgprot inconsistency

Browse Source 
The pgprot flags which are handed into ioremap_page_range() are
different to those which are set in change_page_attr(). The
ioremap_page_range flags are executable, while the c_p_a flags are
not. Also make the mappings global (which is a NOP currently on 32bit,
although CPUs from PPRO+ onwards support it, but that's a separate
fix.)

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Thomas Gleixner 2008-01-30 13:34:04 +01:00 committed by Ingo Molnar
parent ed724be65f
commit a40343497e
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
arch/x86/mm/ioremap_32.c
View File

@ -67,8 +67,7 @@ void __iomem * __ioremap(unsigned long phys_addr, unsigned long size, unsigned l
return NULL; return NULL;
} }
prot = __pgprot(_PAGE_PRESENT | _PAGE_RW | _PAGE_DIRTY prot = MAKE_GLOBAL(__PAGE_KERNEL | flags);
| _PAGE_ACCESSED | flags);
/* /*
* Mappings have to be page-aligned * Mappings have to be page-aligned