leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

dtc2278: fix deadlock on error handling

Browse Source 
Stop abusing ide_lock lock (switch to a private locking).

Fixes same issue as fixed by Alan Cox in atiixp host driver with
commit 6c5f8cc33e.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
This commit is contained in:
Bartlomiej Zolnierkiewicz 2007-10-20 00:32:35 +02:00
parent 2047e15be4
commit a34a8751f3
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/ide/legacy/dtc2278.c
View File

@ -67,18 +67,20 @@ static void sub22 (char b, char c)
} }
} }
static DEFINE_SPINLOCK(dtc2278_lock);
static void dtc2278_set_pio_mode(ide_drive_t *drive, const u8 pio) static void dtc2278_set_pio_mode(ide_drive_t *drive, const u8 pio)
{ {
unsigned long flags; unsigned long flags;
if (pio >= 3) { if (pio >= 3) {
spin_lock_irqsave(&ide_lock, flags); spin_lock_irqsave(&dtc2278_lock, flags);
/* /*
* This enables PIO mode4 (3?) on the first interface * This enables PIO mode4 (3?) on the first interface
*/ */
sub22(1,0xc3); sub22(1,0xc3);
sub22(0,0xa0); sub22(0,0xa0);
spin_unlock_irqrestore(&ide_lock, flags); spin_unlock_irqrestore(&dtc2278_lock, flags);
} else { } else {
/* we don't know how to set it back again.. */ /* we don't know how to set it back again.. */
} }