leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

xfs: simplify if-else condition in xfs_reflink_trim_around_shared

Browse Source 
"else" is not generally useful after a return,
so remove it for clean code.

There is no logical changes.

Signed-off-by: Zeng Heng <zengheng4@huawei.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Dave Chinner <david@fromorbit.com>
This commit is contained in:
Zeng Heng 2022-09-19 06:50:14 +10:00 committed by Dave Chinner
parent de94a2e151
commit a0ebf8c46d
1 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
fs/xfs/xfs_reflink.c
View File

@ -200,7 +200,9 @@ xfs_reflink_trim_around_shared(
if (fbno == NULLAGBLOCK) { if (fbno == NULLAGBLOCK) {
/* No shared blocks at all. */ /* No shared blocks at all. */
return 0; return 0;
} else if (fbno == agbno) { }
if (fbno == agbno) {
/* /*
* The start of this extent is shared. Truncate the * The start of this extent is shared. Truncate the
* mapping at the end of the shared region so that a * mapping at the end of the shared region so that a
@ -210,16 +212,16 @@ xfs_reflink_trim_around_shared(
irec->br_blockcount = flen; irec->br_blockcount = flen;
*shared = true; *shared = true;
return 0; return 0;
} else {
/*
* There's a shared extent midway through this extent.
* Truncate the mapping at the start of the shared
* extent so that a subsequent iteration starts at the
* start of the shared region.
*/
irec->br_blockcount = fbno - agbno;
return 0;
} }
/*
* There's a shared extent midway through this extent.
* Truncate the mapping at the start of the shared
* extent so that a subsequent iteration starts at the
* start of the shared region.
*/
irec->br_blockcount = fbno - agbno;
return 0;
} }
int int