leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

USB: typec: Re-use DEFINE_SHOW_ATTRIBUTE() macro

Browse Source 
...instead of open coding file operations followed by custom ->open()
callbacks per each attribute.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Andy Shevchenko 2018-02-14 18:08:29 +02:00 committed by Greg Kroah-Hartman
parent e23500dd34
commit 9e902c598b
2 changed files with 6 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/usb/typec/fusb302/fusb302.c
View File

@ -199,7 +199,7 @@ static void fusb302_log(struct fusb302_chip *chip, const char *fmt, ...)
va_end(args);
}
static int fusb302_seq_show(struct seq_file *s, void *v)
static int fusb302_debug_show(struct seq_file *s, void *v)
{
struct fusb302_chip *chip = (struct fusb302_chip *)s->private;
int tail;
@ -216,18 +216,7 @@ static int fusb302_seq_show(struct seq_file *s, void *v)
return 0;
}
static int fusb302_debug_open(struct inode *inode, struct file *file)
{
return single_open(file, fusb302_seq_show, inode->i_private);
}
static const struct file_operations fusb302_debug_operations = {
.open = fusb302_debug_open,
.llseek = seq_lseek,
.read = seq_read,
.release = single_release,
};
DEFINE_SHOW_ATTRIBUTE(fusb302_debug);
static struct dentry *rootdir;
@ -242,7 +231,7 @@ static int fusb302_debugfs_init(struct fusb302_chip *chip)
chip->dentry = debugfs_create_file(dev_name(chip->dev),
S_IFREG | 0444, rootdir,
chip, &fusb302_debug_operations);
chip, &fusb302_debug_fops);
return 0;
}

17
drivers/usb/typec/tcpm.c
View File

@ -506,7 +506,7 @@ static void tcpm_log_source_caps(struct tcpm_port *port)
}
}
static int tcpm_seq_show(struct seq_file *s, void *v)
static int tcpm_debug_show(struct seq_file *s, void *v)
{
struct tcpm_port *port = (struct tcpm_port *)s->private;
int tail;
@ -523,18 +523,7 @@ static int tcpm_seq_show(struct seq_file *s, void *v)
return 0;
}
static int tcpm_debug_open(struct inode *inode, struct file *file)
{
return single_open(file, tcpm_seq_show, inode->i_private);
}
static const struct file_operations tcpm_debug_operations = {
.open = tcpm_debug_open,
.llseek = seq_lseek,
.read = seq_read,
.release = single_release,
};
DEFINE_SHOW_ATTRIBUTE(tcpm_debug);
static struct dentry *rootdir;
@ -550,7 +539,7 @@ static int tcpm_debugfs_init(struct tcpm_port *port)
port->dentry = debugfs_create_file(dev_name(port->dev),
S_IFREG | 0444, rootdir,
port, &tcpm_debug_operations);
port, &tcpm_debug_fops);
return 0;
}