leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

audit: no need to walk list in audit_inode if name is NULL

Browse Source 
If name is NULL then the condition in the loop will never be true. Also,
with this change, we can eliminate the check for n->name == NULL since
the equivalence check will never be true if it is.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Jeff Layton 2012-10-10 15:25:21 -04:00 committed by Al Viro
parent 1c2e51e8c1
commit 9cec9d68ae
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
kernel/auditsc.c
View File

@ -2147,11 +2147,15 @@ void __audit_inode(const char *name, const struct dentry *dentry)
if (!context->in_syscall)
return;
if (!name)
goto out_alloc;
list_for_each_entry_reverse(n, &context->names_list, list) {
if (n->name && (n->name == name))
if (n->name == name)
goto out;
}
out_alloc:
/* unable to find the name from a previous getname() */
n = audit_alloc_name(context);
if (!n)