leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

arch/openrisc: Fix issues with access_ok()

Browse Source 
The commit 594cc251fd ("make 'user_access_begin()' do 'access_ok()'")
exposed incorrect implementations of access_ok() macro in several
architectures.  This change fixes 2 issues found in OpenRISC.

OpenRISC was not properly using parenthesis for arguments and also using
arguments twice.  This patch fixes those 2 issues.

I test booted this patch with v5.0-rc1 on qemu and it's working fine.

Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Stafford Horne <shorne@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Stafford Horne 2019-01-08 22:15:15 +09:00 committed by Linus Torvalds
parent 7b55851367
commit 9cb2feb4d2
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
arch/openrisc/include/asm/uaccess.h
View File

@ -58,8 +58,12 @@
/* Ensure that addr is below task's addr_limit */ /* Ensure that addr is below task's addr_limit */
#define __addr_ok(addr) ((unsigned long) addr < get_fs()) #define __addr_ok(addr) ((unsigned long) addr < get_fs())
#define access_ok(addr, size) \ #define access_ok(addr, size) \
__range_ok((unsigned long)addr, (unsigned long)size) ({ \
unsigned long __ao_addr = (unsigned long)(addr); \
unsigned long __ao_size = (unsigned long)(size); \
__range_ok(__ao_addr, __ao_size); \
})
/* /*
* These are the main single-value transfer routines. They automatically * These are the main single-value transfer routines. They automatically