leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

media: coda: do not reassign ctx->tiled_map_type in coda_s_fmt

Browse Source 
This smatch warning:

    coda/coda-common.c:706 coda_s_fmt() warn: missing break? reassigning 'ctx->tiled_map_type'

can be silenced by moving the ctx->tiled_map_type assignment into the
breakout condition. That way the field is not reassigned when falling
through to the next switch statement.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
Philipp Zabel 2017-06-23 07:57:27 -04:00 committed by Mauro Carvalho Chehab
parent 462e8ce009
commit 9c2a455943
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/media/platform/coda/coda-common.c
View File

@ -714,9 +714,10 @@ static int coda_s_fmt(struct coda_ctx *ctx, struct v4l2_format *f,
ctx->tiled_map_type = GDI_TILED_FRAME_MB_RASTER_MAP; ctx->tiled_map_type = GDI_TILED_FRAME_MB_RASTER_MAP;
break; break;
case V4L2_PIX_FMT_NV12: case V4L2_PIX_FMT_NV12:
if (!disable_tiling) {
ctx->tiled_map_type = GDI_TILED_FRAME_MB_RASTER_MAP; ctx->tiled_map_type = GDI_TILED_FRAME_MB_RASTER_MAP;
if (!disable_tiling)
break; break;
}
/* else fall through */ /* else fall through */
case V4L2_PIX_FMT_YUV420: case V4L2_PIX_FMT_YUV420:
case V4L2_PIX_FMT_YVU420: case V4L2_PIX_FMT_YVU420: