leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

md/raid5-cache: remove unnecessary function parameters

Browse Source 
The function parameter 'recovery_list' is not used in
body, we can delete it

Signed-off-by: JackieLiu <liuyun01@kylinos.cn>
Reviewed-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Shaohua Li <shli@fb.com>
This commit is contained in:
JackieLiu 2016-11-28 16:19:18 +08:00 committed by Shaohua Li
parent 462eb7d872
commit 9b69173e5c
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/md/raid5-cache.c
View File

@ -67,7 +67,7 @@ static char *r5c_journal_mode_str[] = {"write-through",
/* /*
* raid5 cache state machine * raid5 cache state machine
* *
* With rhe RAID cache, each stripe works in two phases: * With the RAID cache, each stripe works in two phases:
* - caching phase * - caching phase
* - writing-out phase * - writing-out phase
* *
@ -1674,7 +1674,6 @@ out:
static struct stripe_head * static struct stripe_head *
r5c_recovery_alloc_stripe(struct r5conf *conf, r5c_recovery_alloc_stripe(struct r5conf *conf,
struct list_head *recovery_list,
sector_t stripe_sect, sector_t stripe_sect,
sector_t log_start) sector_t log_start)
{ {
@ -1855,8 +1854,7 @@ r5c_recovery_analyze_meta_block(struct r5l_log *log,
stripe_sect); stripe_sect);
if (!sh) { if (!sh) {
sh = r5c_recovery_alloc_stripe(conf, cached_stripe_list, sh = r5c_recovery_alloc_stripe(conf, stripe_sect, ctx->pos);
stripe_sect, ctx->pos);
/* /*
* cannot get stripe from raid5_get_active_stripe * cannot get stripe from raid5_get_active_stripe
* try replay some stripes * try replay some stripes
@ -1865,8 +1863,7 @@ r5c_recovery_analyze_meta_block(struct r5l_log *log,
r5c_recovery_replay_stripes( r5c_recovery_replay_stripes(
cached_stripe_list, ctx); cached_stripe_list, ctx);
sh = r5c_recovery_alloc_stripe( sh = r5c_recovery_alloc_stripe(
conf, cached_stripe_list, conf, stripe_sect, ctx->pos);
stripe_sect, ctx->pos);
} }
if (!sh) { if (!sh) {
pr_debug("md/raid:%s: Increasing stripe cache size to %d to recovery data on journal.\n", pr_debug("md/raid:%s: Increasing stripe cache size to %d to recovery data on journal.\n",
@ -1875,8 +1872,7 @@ r5c_recovery_analyze_meta_block(struct r5l_log *log,
raid5_set_cache_size(mddev, raid5_set_cache_size(mddev,
conf->min_nr_stripes * 2); conf->min_nr_stripes * 2);
sh = r5c_recovery_alloc_stripe( sh = r5c_recovery_alloc_stripe(
conf, cached_stripe_list, stripe_sect, conf, stripe_sect, ctx->pos);
ctx->pos);
} }
if (!sh) { if (!sh) {
pr_err("md/raid:%s: Cannot get enough stripes due to memory pressure. Recovery failed.\n", pr_err("md/raid:%s: Cannot get enough stripes due to memory pressure. Recovery failed.\n",