leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drm/i915: Add a couple of missing i915_active_fini()

Browse Source 
We use i915_active_fini() as a debug check on the i915_active state
before freeing. If we forget to call it, we may end up angering the
debugobjects contained within.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200731085015.32368-1-chris@chris-wilson.co.uk
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
This commit is contained in:
Chris Wilson 2020-07-31 09:50:09 +01:00 committed by Rodrigo Vivi
parent a22b1a9bb0
commit 9a0a3bebb0
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/drm/i915/display/intel_frontbuffer.c
View File

@ -232,6 +232,8 @@ static void frontbuffer_release(struct kref *ref)
RCU_INIT_POINTER(obj->frontbuffer, NULL); RCU_INIT_POINTER(obj->frontbuffer, NULL);
spin_unlock(&to_i915(obj->base.dev)->fb_tracking.lock); spin_unlock(&to_i915(obj->base.dev)->fb_tracking.lock);
i915_active_fini(&front->write);
i915_gem_object_put(obj); i915_gem_object_put(obj);
kfree_rcu(front, rcu); kfree_rcu(front, rcu);
} }

5
drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c
View File

@ -47,7 +47,10 @@ static int pulse_active(struct i915_active *active)
static void pulse_free(struct kref *kref) static void pulse_free(struct kref *kref)
{ {
kfree(container_of(kref, struct pulse, kref)); struct pulse *p = container_of(kref, typeof(*p), kref);
i915_active_fini(&p->active);
kfree(p);
} }
static void pulse_put(struct pulse *p) static void pulse_put(struct pulse *p)