leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

rxrpc: Downgrade the BUG() for unsupported token type in rxrpc_read()

Browse Source 
If rxrpc_read() (which allows KEYCTL_READ to read a key), sees a token of a
type it doesn't recognise, it can BUG in a couple of places, which is
unnecessary as it can easily get back to userspace.

Fix this to print an error message instead.

Fixes: 99455153d0 ("RxRPC: Parse security index 5 keys (Kerberos 5)")
Signed-off-by: David Howells <dhowells@redhat.com>
This commit is contained in:
David Howells 2020-09-08 22:09:04 +01:00
parent 56305118e0
commit 9a059cd5ca
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
net/rxrpc/key.c
View File

@ -1107,7 +1107,8 @@ static long rxrpc_read(const struct key *key,
break; break;
default: /* we have a ticket we can't encode */ default: /* we have a ticket we can't encode */
BUG(); pr_err("Unsupported key token type (%u)\n",
token->security_index);
continue; continue;
} }
@ -1223,7 +1224,6 @@ static long rxrpc_read(const struct key *key,
break; break;
default: default:
BUG();
break; break;
} }