leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

powerpc/cell/oprofile: Fix test on overlay_tbl_offset in vma_map

Browse Source 
Offset is unsigned and when an address isn't found in the vma map
vma_map_lookup() returns the vma physical address + 0x10000000.

vma_map_lookup used to return 0xffffffff on a failed lookup, but
a change was made to return the vma physical address + 0x10000000
There are two callers of vam_map_lookup: one of them correctly
deals with this new return value, but the other (below) did not.

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Acked-by: Maynard Johnson <maynardj@us.ibm.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
This commit is contained in:
Roel Kluin 2008-10-06 22:38:33 +00:00 committed by Benjamin Herrenschmidt
parent 4538d0ca71
commit 99c840668c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arch/powerpc/oprofile/cell/vma_map.c
View File

@ -229,7 +229,7 @@ struct vma_to_fileoffset_map *create_vma_map(const struct spu *aSpu,
*/ */
overlay_tbl_offset = vma_map_lookup(map, ovly_table_sym, overlay_tbl_offset = vma_map_lookup(map, ovly_table_sym,
aSpu, &grd_val); aSpu, &grd_val);
if (overlay_tbl_offset < 0) { if (overlay_tbl_offset > 0x10000000) {
printk(KERN_ERR "SPU_PROF: " printk(KERN_ERR "SPU_PROF: "
"%s, line %d: Error finding SPU overlay table\n", "%s, line %d: Error finding SPU overlay table\n",
__func__, __LINE__); __func__, __LINE__);