leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

USB: serial: usb_wwan: do not resubmit rx urb on fatal errors

Browse Source 
usb_wwan_indat_callback() shouldn't resubmit rx urb if the previous urb
status is a fatal error. Or the usb controller would keep processing the
new urbs then run into interrupt storm, and has no chance to recover.

Fixes: 6c1ee66a0b ("USB-Serial: Fix error handling of usb_wwan")
Cc: stable@vger.kernel.org
Signed-off-by: Bin Liu <b-liu@ti.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
This commit is contained in:
Bin Liu 2020-05-13 16:36:46 -05:00 committed by Johan Hovold
parent 788a4ee607
commit 986c1748c8
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/serial/usb_wwan.c
View File

@ -270,6 +270,10 @@ static void usb_wwan_indat_callback(struct urb *urb)
if (status) { if (status) {
dev_dbg(dev, "%s: nonzero status: %d on endpoint %02x.\n", dev_dbg(dev, "%s: nonzero status: %d on endpoint %02x.\n",
__func__, status, endpoint); __func__, status, endpoint);
/* don't resubmit on fatal errors */
if (status == -ESHUTDOWN || status == -ENOENT)
return;
} else { } else {
if (urb->actual_length) { if (urb->actual_length) {
tty_insert_flip_string(&port->port, data, tty_insert_flip_string(&port->port, data,