leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[media] jeilinj: fix return of the response code

Browse Source 
drivers/media/usb/gspca/jeilinj.c: In function 'jlj_read1':
drivers/media/usb/gspca/jeilinj.c:117:66: warning: parameter 'response' set but not used [-Wunused-but-set-parameter]
The code still doesn't make much sense, as response is never tested
there.

Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Mauro Carvalho Chehab
2012-10-27 14:54:01 -03:00
parent ede4c3a5a6
commit 9825f37653
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/media/usb/gspca/jeilinj.c
View File

@@ -114,7 +114,7 @@ static void jlj_write2(struct gspca_dev *gspca_dev, unsigned char *command)
} }
/* Responses are one byte only */ /* Responses are one byte only */
static void jlj_read1(struct gspca_dev *gspca_dev, unsigned char response) static void jlj_read1(struct gspca_dev *gspca_dev, unsigned char *response)
{ {
int retval; int retval;
@@ -123,7 +123,7 @@ static void jlj_read1(struct gspca_dev *gspca_dev, unsigned char response)
retval = usb_bulk_msg(gspca_dev->dev, retval = usb_bulk_msg(gspca_dev->dev,
usb_rcvbulkpipe(gspca_dev->dev, 0x84), usb_rcvbulkpipe(gspca_dev->dev, 0x84),
gspca_dev->usb_buf, 1, NULL, 500); gspca_dev->usb_buf, 1, NULL, 500);
response = gspca_dev->usb_buf[0]; *response = gspca_dev->usb_buf[0];
if (retval < 0) { if (retval < 0) {
pr_err("read command [%02x] error %d\n", pr_err("read command [%02x] error %d\n",
gspca_dev->usb_buf[0], retval); gspca_dev->usb_buf[0], retval);
@@ -260,7 +260,7 @@ static int jlj_start(struct gspca_dev *gspca_dev)
if (start_commands[i].delay) if (start_commands[i].delay)
msleep(start_commands[i].delay); msleep(start_commands[i].delay);
if (start_commands[i].ack_wanted) if (start_commands[i].ack_wanted)
jlj_read1(gspca_dev, response); jlj_read1(gspca_dev, &response);
} }
setcamquality(gspca_dev, v4l2_ctrl_g_ctrl(sd->jpegqual)); setcamquality(gspca_dev, v4l2_ctrl_g_ctrl(sd->jpegqual));
msleep(2); msleep(2);