leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

usb: cdns3: Fix sheduling with locks held.

Browse Source 
Patch fix issue in cdns3_ep0_feature_handle_device function.

The function usleep_range can't be used there because this function is
called with locks held and IRQs disabled in
cdns3_device_thread_irq_handler().

To resolve this issue patch replaces usleep_range with mdelay.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Fixes: 7733f6c32e ("usb: cdns3: Add Cadence USB3 DRD Driver")
Reviewed-by: Peter Chen <peter.chen@nxp.com>
Link: https://lore.kernel.org/r/1569484721-4424-1-git-send-email-pawell@cadence.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Pawel Laszczak 2019-09-26 08:58:41 +01:00 committed by Greg Kroah-Hartman
parent 5f318dad72
commit 9816144313
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/usb/cdns3/ep0.c
View File

@ -332,7 +332,7 @@ static int cdns3_ep0_feature_handle_device(struct cdns3_device *priv_dev,
* for sending status stage. * for sending status stage.
* This time should be less then 3ms. * This time should be less then 3ms.
*/ */
usleep_range(1000, 2000); mdelay(1);
cdns3_set_register_bit(&priv_dev->regs->usb_cmd, cdns3_set_register_bit(&priv_dev->regs->usb_cmd,
USB_CMD_STMODE | USB_CMD_STMODE |
USB_STS_TMODE_SEL(tmode - 1)); USB_STS_TMODE_SEL(tmode - 1));