leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

power: supply: cpcap-battery: Fix missing power_supply_put()

Browse Source 
Fix missing power_supply_put().

Cc: Arthur Demchenkov <spinal.by@gmail.com>
Cc: Carl Philipp Klemm <philipp@uvos.xyz>
Cc: Merlijn Wajer <merlijn@wizzup.org>
Cc: Pavel Machek <pavel@ucw.cz>
Fixes: 8b0134cc14 ("power: supply: cpcap-battery: Fix handling of lowered charger voltage")
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
This commit is contained in:
Tony Lindgren 2021-01-10 21:53:50 +02:00 committed by Sebastian Reichel
parent 4bff91bb32
commit 97456a24ac
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/power/supply/cpcap-battery.c
View File

@ -568,17 +568,21 @@ static int cpcap_battery_update_charger(struct cpcap_battery_ddata *ddata,
POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE, POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE,
&prop); &prop);
if (error) if (error)
return error; goto out_put;
/* Allow charger const voltage lower than battery const voltage */ /* Allow charger const voltage lower than battery const voltage */
if (const_charge_voltage > prop.intval) if (const_charge_voltage > prop.intval)
return 0; goto out_put;
val.intval = const_charge_voltage; val.intval = const_charge_voltage;
return power_supply_set_property(charger, error = power_supply_set_property(charger,
POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE, POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE,
&val); &val);
out_put:
power_supply_put(charger);
return error;
} }
static int cpcap_battery_set_property(struct power_supply *psy, static int cpcap_battery_set_property(struct power_supply *psy,