leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drm/tegra: hub: Remove bogus connection mutex check

Browse Source 
The Tegra DRM never actually took that lock, so the driver was broken
until generic locking was added in commit:

	commit b962a12050
	Author: Rob Clark <robdclark@gmail.com>
	Date:   Mon Oct 22 14:31:22 2018 +0200

	    drm/atomic: integrate modeset lock with private objects

It's now no longer necessary to take that lock, so drop the check.

v2: add rationale for why it is now safe to drop the check (Daniel)

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Thierry Reding <treding@nvidia.com>
This commit is contained in:
Thierry Reding
2019-12-03 17:19:06 +01:00
parent 84db889e6d
commit 9569c3e922
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/gpu/drm/tegra/hub.c
View File

@@ -605,11 +605,8 @@ static struct tegra_display_hub_state *
tegra_display_hub_get_state(struct tegra_display_hub *hub, tegra_display_hub_get_state(struct tegra_display_hub *hub,
struct drm_atomic_state *state) struct drm_atomic_state *state)
{ {
struct drm_device *drm = dev_get_drvdata(hub->client.parent);
struct drm_private_state *priv; struct drm_private_state *priv;
WARN_ON(!drm_modeset_is_locked(&drm->mode_config.connection_mutex));
priv = drm_atomic_get_private_obj_state(state, &hub->base); priv = drm_atomic_get_private_obj_state(state, &hub->base);
if (IS_ERR(priv)) if (IS_ERR(priv))
return ERR_CAST(priv); return ERR_CAST(priv);