leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mfd: ipaq-micro: Fix coding style errors/warnings reported by checkpatch

Browse Source 
This is part of an effort to clean-up the MFD subsystem.

ERROR: space required before the open parenthesis '('
+                       if(!micro->msg)

WARNING: unnecessary whitespace before a quoted newline
+                       dev_dbg(micro->dev, "key message ignored, no handle \n");

WARNING: unnecessary whitespace before a quoted newline
+                       dev_dbg(micro->dev, "touchscreen message ignored, no handle \n");

WARNING: space prohibited before semicolon
+               rx->id = (ch & 0xf0) >> 4 ;

total: 1 errors, 3 warnings, 482 lines checked

Signed-off-by: Lee Jones <lee.jones@linaro.org>
This commit is contained in:
Lee Jones 2014-07-21 16:08:55 +01:00
parent d69d4212b8
commit 9336fe9104
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/mfd/ipaq-micro.c
View File

@ -115,7 +115,7 @@ static void micro_rx_msg(struct ipaq_micro *micro, u8 id, int len, u8 *data)
} else { } else {
dev_err(micro->dev, dev_err(micro->dev,
"out of band RX message 0x%02x\n", id); "out of band RX message 0x%02x\n", id);
if(!micro->msg) if (!micro->msg)
dev_info(micro->dev, "no message queued\n"); dev_info(micro->dev, "no message queued\n");
else else
dev_info(micro->dev, "expected message %02x\n", dev_info(micro->dev, "expected message %02x\n",
@ -126,13 +126,13 @@ static void micro_rx_msg(struct ipaq_micro *micro, u8 id, int len, u8 *data)
if (micro->key) if (micro->key)
micro->key(micro->key_data, len, data); micro->key(micro->key_data, len, data);
else else
dev_dbg(micro->dev, "key message ignored, no handle \n"); dev_dbg(micro->dev, "key message ignored, no handle\n");
break; break;
case MSG_TOUCHSCREEN: case MSG_TOUCHSCREEN:
if (micro->ts) if (micro->ts)
micro->ts(micro->ts_data, len, data); micro->ts(micro->ts_data, len, data);
else else
dev_dbg(micro->dev, "touchscreen message ignored, no handle \n"); dev_dbg(micro->dev, "touchscreen message ignored, no handle\n");
break; break;
default: default:
dev_err(micro->dev, dev_err(micro->dev,
@ -154,7 +154,7 @@ static void micro_process_char(struct ipaq_micro *micro, u8 ch)
rx->state = STATE_ID; /* Next byte is the id and len */ rx->state = STATE_ID; /* Next byte is the id and len */
break; break;
case STATE_ID: /* Looking for id and len byte */ case STATE_ID: /* Looking for id and len byte */
rx->id = (ch & 0xf0) >> 4 ; rx->id = (ch & 0xf0) >> 4;
rx->len = (ch & 0x0f); rx->len = (ch & 0x0f);
rx->index = 0; rx->index = 0;
rx->chksum = ch; rx->chksum = ch;