leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

namei: ignore ERR/NULL names in putname()

Browse Source 
Supporting ERR/NULL names in putname() makes callers code cleaner, and
is what some other path walking functions already support for the same
reason.

This also removes a few existing IS_ERR checks before putname().

Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Link: https://lore.kernel.org/io-uring/CAHk-=wgCac9hBsYzKMpHk0EbLgQaXR=OUAjHaBtaY+G8A9KhFg@mail.gmail.com/
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Dmitry Kadashev <dkadashev@gmail.com>
Link: https://lore.kernel.org/r/20210708063447.3556403-2-dkadashev@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Dmitry Kadashev 2021-07-08 13:34:37 +07:00 committed by Jens Axboe
parent 26578cda3d
commit 91ef658fb8
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
fs/namei.c
View File

@ -247,6 +247,9 @@ getname_kernel(const char * filename)
void putname(struct filename *name) void putname(struct filename *name)
{ {
if (IS_ERR_OR_NULL(name))
return;
BUG_ON(name->refcnt <= 0); BUG_ON(name->refcnt <= 0);
if (--name->refcnt > 0) if (--name->refcnt > 0)
@ -4728,11 +4731,9 @@ exit1:
goto retry; goto retry;
} }
put_both: put_both:
if (!IS_ERR(from)) putname(from);
putname(from);
put_new: put_new:
if (!IS_ERR(to)) putname(to);
putname(to);
return error; return error;
} }