leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: fddi: skfp: ecm: Protect 'if' when AIX_EVENT is not defined

Browse Source 
When AIX_EVENT is not defined, the 'if' body will be empty, which
makes GCC complain.  Place bracketing around the invocation to protect
it.

Fixes the following W=1 kernel build warning(s):

 drivers/net/fddi/skfp/ecm.c: In function ‘ecm_fsm’:
 drivers/net/fddi/skfp/ecm.c:153:29: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]

Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20201102114512.1062724-2-lee.jones@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Lee Jones 2020-11-02 11:44:43 +00:00 committed by Jakub Kicinski
parent 626d667b19
commit 918895bf61
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/fddi/skfp/ecm.c
View File

@ -147,10 +147,11 @@ static void ecm_fsm(struct s_smc *smc, int cmd)
/* For AIX event notification: */ /* For AIX event notification: */
/* Is a disconnect command remotely issued ? */ /* Is a disconnect command remotely issued ? */
if (cmd == EC_DISCONNECT && if (cmd == EC_DISCONNECT &&
smc->mib.fddiSMTRemoteDisconnectFlag == TRUE) smc->mib.fddiSMTRemoteDisconnectFlag == TRUE) {
AIX_EVENT (smc, (u_long) CIO_HARD_FAIL, (u_long) AIX_EVENT (smc, (u_long) CIO_HARD_FAIL, (u_long)
FDDI_REMOTE_DISCONNECT, smt_get_event_word(smc), FDDI_REMOTE_DISCONNECT, smt_get_event_word(smc),
smt_get_error_word(smc) ); smt_get_error_word(smc) );
}
/*jd 05-Aug-1999 Bug #10419 "Port Disconnect fails at Dup MAc Cond."*/ /*jd 05-Aug-1999 Bug #10419 "Port Disconnect fails at Dup MAc Cond."*/
if (cmd == EC_CONNECT) { if (cmd == EC_CONNECT) {