leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: comedi: das1800: use comedi_offset_munge() for analog output

Browse Source 
The analog outputs expect 2's complement data. For aesthetics, use
the helper function to handle the munging instead of depending on
the boardinfo 'resolution'.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2016-04-08 12:41:37 -07:00 committed by Greg Kroah-Hartman
parent 7a9254962b
commit 90f39b9f99
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/staging/comedi/drivers/das1800.c
View File

@ -1132,8 +1132,7 @@ static int das1800_ao_insn_write(struct comedi_device *dev,
unsigned short output;
unsigned long irq_flags;
/* card expects two's complement data */
output = data[0] - (1 << (board->resolution - 1));
output = comedi_offset_munge(s, data[0]);
/* if the write is to the 'update' channel, we need to remember its value */
if (chan == update_chan)
devpriv->ao_update_bits = output;