forked from Minki/linux
media: max9271: Fix GPIO enable/disable
Fix GPIO enable/disable operations which wrongly read the 0x0f register
to obtain the current mask of the enabled lines instead of using
the correct 0x0e register.
Also fix access to bit 0 of the register which is marked as reserved.
Fixes: 34009bffc1
("media: i2c: Add RDACM20 driver")
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
parent
0ae426ebd0
commit
909a0a189c
@ -223,12 +223,12 @@ int max9271_enable_gpios(struct max9271_device *dev, u8 gpio_mask)
|
||||
{
|
||||
int ret;
|
||||
|
||||
ret = max9271_read(dev, 0x0f);
|
||||
ret = max9271_read(dev, 0x0e);
|
||||
if (ret < 0)
|
||||
return 0;
|
||||
|
||||
/* BIT(0) reserved: GPO is always enabled. */
|
||||
ret |= gpio_mask | BIT(0);
|
||||
ret |= (gpio_mask & ~BIT(0));
|
||||
ret = max9271_write(dev, 0x0e, ret);
|
||||
if (ret < 0) {
|
||||
dev_err(&dev->client->dev, "Failed to enable gpio (%d)\n", ret);
|
||||
@ -245,12 +245,12 @@ int max9271_disable_gpios(struct max9271_device *dev, u8 gpio_mask)
|
||||
{
|
||||
int ret;
|
||||
|
||||
ret = max9271_read(dev, 0x0f);
|
||||
ret = max9271_read(dev, 0x0e);
|
||||
if (ret < 0)
|
||||
return 0;
|
||||
|
||||
/* BIT(0) reserved: GPO cannot be disabled */
|
||||
ret &= (~gpio_mask | BIT(0));
|
||||
ret &= ~(gpio_mask | BIT(0));
|
||||
ret = max9271_write(dev, 0x0e, ret);
|
||||
if (ret < 0) {
|
||||
dev_err(&dev->client->dev, "Failed to disable gpio (%d)\n", ret);
|
||||
|
Loading…
Reference in New Issue
Block a user