leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: et131x: Remove useless return variables

Browse Source 
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.

Verified by compilation only.

The coccinelle script that find and fixes this issue is:
// <smpl>
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Peter Senna Tschudin 2014-05-20 12:33:45 +02:00 committed by Greg Kroah-Hartman
parent 43b54cc91b
commit 8ea6cdf527
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/staging/et131x/et131x.c
View File

@ -4237,7 +4237,6 @@ static int et131x_ioctl(struct net_device *netdev, struct ifreq *reqbuf,
static int et131x_set_packet_filter(struct et131x_adapter *adapter) static int et131x_set_packet_filter(struct et131x_adapter *adapter)
{ {
int filter = adapter->packet_filter; int filter = adapter->packet_filter;
int status = 0;
u32 ctrl; u32 ctrl;
u32 pf_ctrl; u32 pf_ctrl;
@ -4288,7 +4287,7 @@ static int et131x_set_packet_filter(struct et131x_adapter *adapter)
writel(pf_ctrl, &adapter->regs->rxmac.pf_ctrl); writel(pf_ctrl, &adapter->regs->rxmac.pf_ctrl);
writel(ctrl, &adapter->regs->rxmac.ctrl); writel(ctrl, &adapter->regs->rxmac.ctrl);
} }
return status; return 0;
} }
/* et131x_multicast - The handler to configure multicasting on the interface */ /* et131x_multicast - The handler to configure multicasting on the interface */