leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gpio: Fix sch_gpio warning

Browse Source 
We need to check for gpiochip_remove() errors.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
This commit is contained in:
Samuel Ortiz 2010-03-05 17:14:01 +01:00
parent be9b06b2d8
commit 8e7aafe41b
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
drivers/gpio/sch_gpio.c
View File

@ -229,7 +229,10 @@ static int __devinit sch_gpio_probe(struct platform_device *pdev)
return 0; return 0;
err_sch_gpio_resume: err_sch_gpio_resume:
gpiochip_remove(&sch_gpio_core); err = gpiochip_remove(&sch_gpio_core);
if (err)
dev_err(&pdev->dev, "%s failed, %d\n",
"gpiochip_remove()", err);
err_sch_gpio_core: err_sch_gpio_core:
release_region(res->start, resource_size(res)); release_region(res->start, resource_size(res));
@ -242,13 +245,23 @@ static int __devexit sch_gpio_remove(struct platform_device *pdev)
{ {
struct resource *res; struct resource *res;
if (gpio_ba) { if (gpio_ba) {
gpiochip_remove(&sch_gpio_core); int err;
gpiochip_remove(&sch_gpio_resume);
err = gpiochip_remove(&sch_gpio_core);
if (err)
dev_err(&pdev->dev, "%s failed, %d\n",
"gpiochip_remove()", err);
err = gpiochip_remove(&sch_gpio_resume);
if (err)
dev_err(&pdev->dev, "%s failed, %d\n",
"gpiochip_remove()", err);
res = platform_get_resource(pdev, IORESOURCE_IO, 0); res = platform_get_resource(pdev, IORESOURCE_IO, 0);
release_region(res->start, resource_size(res)); release_region(res->start, resource_size(res));
gpio_ba = 0; gpio_ba = 0;
return err;
} }
return 0; return 0;