leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

genetlink: use parsed attrs in dumppolicy

Browse Source 
Attributes are already parsed based on the policy specified
in the family and ready-to-use in info->attrs. No need to
call genlmsg_parse() again.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jakub Kicinski 2020-10-02 14:49:59 -07:00 committed by David S. Miller
parent 7c1e0926da
commit 8e1ed28fd8
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
net/netlink/genetlink.c
View File

@ -1117,18 +1117,13 @@ struct ctrl_dump_policy_ctx {
static int ctrl_dumppolicy_start(struct netlink_callback *cb)
{
const struct genl_dumpit_info *info = genl_dumpit_info(cb);
struct ctrl_dump_policy_ctx *ctx = (void *)cb->ctx;
struct nlattr *tb[CTRL_ATTR_MAX + 1];
struct nlattr **tb = info->attrs;
const struct genl_family *rt;
int err;
BUILD_BUG_ON(sizeof(*ctx) > sizeof(cb->ctx));
err = genlmsg_parse(cb->nlh, &genl_ctrl, tb, genl_ctrl.maxattr,
genl_ctrl.policy, cb->extack);
if (err)
return err;
if (!tb[CTRL_ATTR_FAMILY_ID] && !tb[CTRL_ATTR_FAMILY_NAME])
return -EINVAL;