leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sd: bad return code of init_sd

Browse Source 
In init_sd function, if kmem_cache_create or mempool_create_slab_pools
calls fail, the error will not be correclty reported because
class_register previously set the value of err to 0.

Signed-off-by: Clément Calmels <clement.calmels@free.fr>
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
This commit is contained in:
Clément Calmels 2014-06-03 23:34:25 +02:00 committed by Christoph Hellwig
parent cb2fb68d06
commit 8d964478b2
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/scsi/sd.c
View File

@ -3212,12 +3212,14 @@ static int __init init_sd(void)
0, 0, NULL); 0, 0, NULL);
if (!sd_cdb_cache) { if (!sd_cdb_cache) {
printk(KERN_ERR "sd: can't init extended cdb cache\n"); printk(KERN_ERR "sd: can't init extended cdb cache\n");
err = -ENOMEM;
goto err_out_class; goto err_out_class;
} }
sd_cdb_pool = mempool_create_slab_pool(SD_MEMPOOL_SIZE, sd_cdb_cache); sd_cdb_pool = mempool_create_slab_pool(SD_MEMPOOL_SIZE, sd_cdb_cache);
if (!sd_cdb_pool) { if (!sd_cdb_pool) {
printk(KERN_ERR "sd: can't init extended cdb pool\n"); printk(KERN_ERR "sd: can't init extended cdb pool\n");
err = -ENOMEM;
goto err_out_cache; goto err_out_cache;
} }