leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

block: adapt blk_mq_plug() to not plug for writes that require a zone lock

Browse Source 
The current implementation of blk_mq_plug() disables plugging for all
operations that involves a transfer to the device as we just check if
the last bit in op_is_write() function.

Modify blk_mq_plug() to disable plugging only for REQ_OP_WRITE and
REQ_OP_WRITE_ZEROS as they might require a zone lock.

Suggested-by: Christoph Hellwig <hch@lst.de>
Suggested-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Link: https://lore.kernel.org/r/20220929074745.103073-2-p.raghav@samsung.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Pankaj Raghav 2022-09-29 09:47:44 +02:00 committed by Jens Axboe
parent dfdcbf1fc3
commit 8cafdb5ab9
3 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
block/blk-mq.h
View File

@ -312,7 +312,8 @@ static inline void blk_mq_clear_mq_map(struct blk_mq_queue_map *qmap)
static inline struct blk_plug *blk_mq_plug( struct bio *bio) static inline struct blk_plug *blk_mq_plug( struct bio *bio)
{ {
/* Zoned block device write operation case: do not plug the BIO */ /* Zoned block device write operation case: do not plug the BIO */
if (bdev_is_zoned(bio->bi_bdev) && op_is_write(bio_op(bio))) if (IS_ENABLED(CONFIG_BLK_DEV_ZONED) &&
bdev_op_is_zoned_write(bio->bi_bdev, bio_op(bio)))
return NULL; return NULL;
/* /*

9
block/blk-zoned.c
View File

@ -63,13 +63,10 @@ bool blk_req_needs_zone_write_lock(struct request *rq)
if (!rq->q->disk->seq_zones_wlock) if (!rq->q->disk->seq_zones_wlock)
return false; return false;
switch (req_op(rq)) { if (bdev_op_is_zoned_write(rq->q->disk->part0, req_op(rq)))
case REQ_OP_WRITE_ZEROES:
case REQ_OP_WRITE:
return blk_rq_zone_is_seq(rq); return blk_rq_zone_is_seq(rq);
default:
return false; return false;
}
} }
EXPORT_SYMBOL_GPL(blk_req_needs_zone_write_lock); EXPORT_SYMBOL_GPL(blk_req_needs_zone_write_lock);

9
include/linux/blkdev.h
View File

@ -1304,6 +1304,15 @@ static inline bool bdev_is_zoned(struct block_device *bdev)
return false; return false;
} }
static inline bool bdev_op_is_zoned_write(struct block_device *bdev,
blk_opf_t op)
{
if (!bdev_is_zoned(bdev))
return false;
return op == REQ_OP_WRITE || op == REQ_OP_WRITE_ZEROES;
}
static inline sector_t bdev_zone_sectors(struct block_device *bdev) static inline sector_t bdev_zone_sectors(struct block_device *bdev)
{ {
struct request_queue *q = bdev_get_queue(bdev); struct request_queue *q = bdev_get_queue(bdev);