drm/msm: Remove redundant calls to drm_connector_register_all()
Up to now, the recommendation was for drivers to call drm_dev_register() followed by drm_connector_register_all(). Now that drm_connector_register() is safe against multiple invocations, we can move drm_connector_register_all() to drm_dev_register() and not suffer from any backwards compatibility issues with drivers not following the more rigorous init ordering. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Rob Clark <robdclark@gmail.com> Cc: David Airlie <airlied@linux.ie> Cc: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org Cc: freedreno@lists.freedesktop.org Tested-by: Archit Taneja <architt@codeaurora.org> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: http://patchwork.freedesktop.org/patch/msgid/1466151923-1572-7-git-send-email-chris@chris-wilson.co.uk
This commit is contained in:
		
							parent
							
								
									6c62c98fa4
								
							
						
					
					
						commit
						8c2d8ed95f
					
				| @ -197,8 +197,6 @@ static int msm_drm_uninit(struct device *dev) | ||||
| 
 | ||||
| 	drm_kms_helper_poll_fini(ddev); | ||||
| 
 | ||||
| 	drm_connector_unregister_all(ddev); | ||||
| 
 | ||||
| 	drm_dev_unregister(ddev); | ||||
| 
 | ||||
| #ifdef CONFIG_DRM_FBDEV_EMULATION | ||||
| @ -431,12 +429,6 @@ static int msm_drm_init(struct device *dev, struct drm_driver *drv) | ||||
| 	if (ret) | ||||
| 		goto fail; | ||||
| 
 | ||||
| 	ret = drm_connector_register_all(ddev); | ||||
| 	if (ret) { | ||||
| 		dev_err(dev, "failed to register connectors\n"); | ||||
| 		goto fail; | ||||
| 	} | ||||
| 
 | ||||
| 	drm_mode_config_reset(ddev); | ||||
| 
 | ||||
| #ifdef CONFIG_DRM_FBDEV_EMULATION | ||||
|  | ||||
		Loading…
	
		Reference in New Issue
	
	Block a user