leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

rtc: ds1685: passing bogus values to irq_restore

Browse Source 
We call spin_lock_irqrestore with "flags" set to zero instead of to the
value from spin_lock_irqsave().

Fixes: aaaf5fbf56 ('rtc: add driver for DS1685 family of real time clocks')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
This commit is contained in:
Dan Carpenter 2016-03-02 13:07:45 +03:00 committed by Alexandre Belloni
parent 7e84536cb9
commit 8c09b9fdec
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/rtc/rtc-ds1685.c
View File

@ -187,9 +187,9 @@ ds1685_rtc_end_data_access(struct ds1685_priv *rtc)
* Only use this where you are certain another lock will not be held. * Only use this where you are certain another lock will not be held.
*/ */
static inline void static inline void
ds1685_rtc_begin_ctrl_access(struct ds1685_priv *rtc, unsigned long flags) ds1685_rtc_begin_ctrl_access(struct ds1685_priv *rtc, unsigned long *flags)
{ {
spin_lock_irqsave(&rtc->lock, flags); spin_lock_irqsave(&rtc->lock, *flags);
ds1685_rtc_switch_to_bank1(rtc); ds1685_rtc_switch_to_bank1(rtc);
} }
@ -1300,7 +1300,7 @@ ds1685_rtc_sysfs_ctrl_regs_store(struct device *dev,
{ {
struct ds1685_priv *rtc = dev_get_drvdata(dev); struct ds1685_priv *rtc = dev_get_drvdata(dev);
u8 reg = 0, bit = 0, tmp; u8 reg = 0, bit = 0, tmp;
unsigned long flags = 0; unsigned long flags;
long int val = 0; long int val = 0;
const struct ds1685_rtc_ctrl_regs *reg_info = const struct ds1685_rtc_ctrl_regs *reg_info =
ds1685_rtc_sysfs_ctrl_regs_lookup(attr->attr.name); ds1685_rtc_sysfs_ctrl_regs_lookup(attr->attr.name);
@ -1321,7 +1321,7 @@ ds1685_rtc_sysfs_ctrl_regs_store(struct device *dev,
bit = reg_info->bit; bit = reg_info->bit;
/* Safe to spinlock during a write. */ /* Safe to spinlock during a write. */
ds1685_rtc_begin_ctrl_access(rtc, flags); ds1685_rtc_begin_ctrl_access(rtc, &flags);
tmp = rtc->read(rtc, reg); tmp = rtc->read(rtc, reg);
rtc->write(rtc, reg, (val ? (tmp | bit) : (tmp & ~(bit)))); rtc->write(rtc, reg, (val ? (tmp | bit) : (tmp & ~(bit))));
ds1685_rtc_end_ctrl_access(rtc, flags); ds1685_rtc_end_ctrl_access(rtc, flags);