forked from Minki/linux
wl12xx: fix "JOIN while associated" commentary
Issuing multiple JOIN commands to the wl12xx's firmware, while we're associated, might have undesired implications, so the driver prints a message when that happens, and warn developers who check out the source. Update the commentary in order to consider the one valid scenario where this can happen: roaming. Cautiously keep the message for now, until we either gain confidence there are no unintentional JOIN-while-associated events, or until we move to the new multi-role fw who solves this multiple-join issue for good. Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com> Signed-off-by: Luciano Coelho <coelho@ti.com>
This commit is contained in:
parent
c5745187a4
commit
8bf69aae4c
@ -1591,10 +1591,10 @@ static int wl1271_join(struct wl1271 *wl, bool set_assoc)
|
||||
* One of the side effects of the JOIN command is that is clears
|
||||
* WPA/WPA2 keys from the chipset. Performing a JOIN while associated
|
||||
* to a WPA/WPA2 access point will therefore kill the data-path.
|
||||
* Currently there is no supported scenario for JOIN during
|
||||
* association - if it becomes a supported scenario, the WPA/WPA2 keys
|
||||
* must be handled somehow.
|
||||
*
|
||||
* Currently the only valid scenario for JOIN during association
|
||||
* is on roaming, in which case we will also be given new keys.
|
||||
* Keep the below message for now, unless it starts bothering
|
||||
* users who really like to roam a lot :)
|
||||
*/
|
||||
if (test_bit(WL1271_FLAG_STA_ASSOCIATED, &wl->flags))
|
||||
wl1271_info("JOIN while associated.");
|
||||
|
Loading…
Reference in New Issue
Block a user