leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: rtl8723bs: fix copy of overlapping memory

Browse Source 
Currently the rtw_sprintf prints the contents of thread_name
onto thread_name and this can lead to a potential copy of a
string over itself. Avoid this by printing the literal string RTWHALXT
instread of the contents of thread_name.

Addresses-Coverity: ("copy of overlapping memory")
Fixes: 554c0a3abf ("staging: Add rtl8723bs sdio wifi driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20200126220549.9849-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Colin Ian King 2020-01-26 22:05:49 +00:00 committed by Greg Kroah-Hartman
parent 6d67b0290b
commit 8ae9a588ca
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
View File

@ -476,14 +476,13 @@ int rtl8723bs_xmit_thread(void *context)
s32 ret; s32 ret;
struct adapter *padapter; struct adapter *padapter;
struct xmit_priv *pxmitpriv; struct xmit_priv *pxmitpriv;
u8 thread_name[20] = "RTWHALXT"; u8 thread_name[20];
ret = _SUCCESS; ret = _SUCCESS;
padapter = context; padapter = context;
pxmitpriv = &padapter->xmitpriv; pxmitpriv = &padapter->xmitpriv;
rtw_sprintf(thread_name, 20, "%s-"ADPT_FMT, thread_name, ADPT_ARG(padapter)); rtw_sprintf(thread_name, 20, "RTWHALXT-" ADPT_FMT, ADPT_ARG(padapter));
thread_enter(thread_name); thread_enter(thread_name);
DBG_871X("start "FUNC_ADPT_FMT"\n", FUNC_ADPT_ARG(padapter)); DBG_871X("start "FUNC_ADPT_FMT"\n", FUNC_ADPT_ARG(padapter));