leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PCI: mobiveil: Fix INTx interrupt clearing in mobiveil_pcie_isr()

Browse Source 
The current INTx handling function clears all interrupts after
handling the first pending; this can potentially cause missing INTx
detection. Fix the code to clear only the handled INTx IRQ.

Fixes: 9af6bcb11e ("PCI: mobiveil: Add Mobiveil PCIe Host Bridge IP driver")
Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Minghuan Lian <Minghuan.Lian@nxp.com>
Reviewed-by: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>
Acked-by: Karthikeyan Mitran <m.karthikeyan@mobiveil.co.in>
Tested-by: Karthikeyan Mitran <m.karthikeyan@mobiveil.co.in>
This commit is contained in:
Hou Zhiqiang
2019-07-05 17:56:56 +08:00
committed by Lorenzo Pieralisi
parent 526c101dde
commit 8a4f9fea26
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/pci/controller/pcie-mobiveil.c
View File

@@ -371,9 +371,8 @@ static void mobiveil_pcie_isr(struct irq_desc *desc)
dev_err_ratelimited(dev, "unexpected IRQ, INT%d\n", dev_err_ratelimited(dev, "unexpected IRQ, INT%d\n",
bit); bit);
/* clear interrupt */ /* clear interrupt handled */
csr_writel(pcie, csr_writel(pcie, 1 << (PAB_INTX_START + bit),
shifted_status << PAB_INTX_START,
PAB_INTP_AMBA_MISC_STAT); PAB_INTP_AMBA_MISC_STAT);
} }