leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: ks7010: change length type to unsigned

Browse Source 
Length undergoes type conversion when passed (indirectly) as an
argument for parameter of type 'unsigned int'. If length is negative
this is a bug (the value after conversion is large).

Declare 'length' to be an unsigned type instead of a signed type.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tobin C. Harding <me@tobin.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Tobin C. Harding 2017-04-10 13:15:40 +10:00 committed by Greg Kroah-Hartman
parent 5141e9c634
commit 881f76b976
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/staging/ks7010/ks7010_sdio.c
View File

@ -712,7 +712,7 @@ static int ks7010_upload_firmware(struct ks_sdio_card *card)
unsigned char *rom_buf;
unsigned char rw_data = 0;
int ret;
int length;
unsigned int length;
const struct firmware *fw_entry = NULL;
/* buffer allocate */