leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Staging: intel_sst: return -EFAULT if copy_to_user() fails

Browse Source 
copy_to_user() returns the number of bytes remaining to be copied but we
want to return an error code.  And that error code is -EFAULT not -EIO.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Dan Carpenter 2010-10-15 05:44:07 +02:00 committed by Greg Kroah-Hartman
parent e98cb27681
commit 87b554a04a
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/intel_sst/intel_sst_app_interface.c
View File

@ -861,6 +861,8 @@ long intel_sst_ioctl(struct file *file_ptr, unsigned int cmd, unsigned long arg)
str_info->src = SST_DRV;
retval = copy_to_user(&str_param->stream_id,
&retval, sizeof(__u32));
if (retval)
retval = -EFAULT;
} else {
if (retval == -SST_ERR_INVALID_PARAMS)
retval = -EINVAL;
@ -934,7 +936,7 @@ long intel_sst_ioctl(struct file *file_ptr, unsigned int cmd, unsigned long arg)
retval = copy_to_user((struct snd_sst_vol *)arg,
&get_vol, sizeof(get_vol));
if (retval) {
retval = -EIO;
retval = -EFAULT;
break;
}
/*sst_print_get_vol_info(str_id, &get_vol);*/