leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

of/unittest: Missing unlocks on error

Browse Source 
Static checkers complain that we should unlock before returning.  Which
is true.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Frank Rowand <frank.rowand@sony.com>
Signed-off-by: Rob Herring <robh@kernel.org>
This commit is contained in:
Dan Carpenter 2017-05-03 22:49:50 +03:00 committed by Rob Herring
parent ee320b33b4
commit 8756cd1ded
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/of/unittest.c
View File

@ -2210,14 +2210,14 @@ static __init void of_unittest_overlay_high_level(void)
unittest(0, unittest(0,
"duplicate property '%s' in overlay_base node __symbols__", "duplicate property '%s' in overlay_base node __symbols__",
prop->name); prop->name);
return; goto err_unlock;
} }
ret = __of_add_property_sysfs(of_symbols, prop); ret = __of_add_property_sysfs(of_symbols, prop);
if (ret) { if (ret) {
unittest(0, unittest(0,
"unable to add property '%s' in overlay_base node __symbols__ to sysfs", "unable to add property '%s' in overlay_base node __symbols__ to sysfs",
prop->name); prop->name);
return; goto err_unlock;
} }
} }
} }
@ -2232,6 +2232,10 @@ static __init void of_unittest_overlay_high_level(void)
unittest(overlay_data_add(2), unittest(overlay_data_add(2),
"Adding overlay 'overlay_bad_phandle' failed\n"); "Adding overlay 'overlay_bad_phandle' failed\n");
return;
err_unlock:
mutex_unlock(&of_mutex);
} }
#else #else