leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

spi: pic32: Fix checking return value of devm_ioremap_resource

Browse Source 
devm_ioremap_resource() returns ERR_PTR on error.
Also remove the redundant dev_err message, the implementation of
devm_ioremap_resource() already print error messages on error paths.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Axel Lin 2016-04-27 16:19:26 +08:00 committed by Mark Brown
parent 2452ee2525
commit 866e48b099
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/spi/spi-pic32.c
View File

@ -711,10 +711,9 @@ static int pic32_spi_hw_probe(struct platform_device *pdev,
mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
pic32s->regs = devm_ioremap_resource(&pdev->dev, mem); pic32s->regs = devm_ioremap_resource(&pdev->dev, mem);
if (!pic32s->regs) { if (IS_ERR(pic32s->regs))
dev_err(&pdev->dev, "ioremap() failed\n"); return PTR_ERR(pic32s->regs);
return -ENOMEM;
}
pic32s->dma_base = mem->start; pic32s->dma_base = mem->start;
/* get irq resources: err-irq, rx-irq, tx-irq */ /* get irq resources: err-irq, rx-irq, tx-irq */