leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[media] cx24117: fix a buffer overflow when checking userspace params

Browse Source 
The maximum size for a DiSEqC command is 6, according to the
userspace API. However, the code allows to write up much more values:
	drivers/media/dvb-frontends/cx24116.c:983 cx24116_send_diseqc_msg() error: buffer overflow 'd->msg' 6 <= 23

Cc: stable@vger.kernel.org
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
Mauro Carvalho Chehab 2015-04-28 19:03:59 -03:00
parent d7b76c91f4
commit 82e3b88b67
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/media/dvb-frontends/cx24117.c
View File

@ -1043,7 +1043,7 @@ static int cx24117_send_diseqc_msg(struct dvb_frontend *fe,
dev_dbg(&state->priv->i2c->dev, ")\n"); dev_dbg(&state->priv->i2c->dev, ")\n");
/* Validate length */ /* Validate length */
if (d->msg_len > 15) if (d->msg_len > sizeof(d->msg))
return -EINVAL; return -EINVAL;
/* DiSEqC message */ /* DiSEqC message */