leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

rhashtable: Revise incorrect comment on r{hl, hash}table_walk_enter()

Browse Source 
Neither rhashtable_walk_enter() or rhltable_walk_enter() sleep, though
they do take a spinlock without irq protection.
So revise the comments to accurately state the contexts in which
these functions can be called.

Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
NeilBrown
2018-04-24 08:29:13 +10:00
committed by David S. Miller
parent 0c6f69a5e3
commit 82266e98dd
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
include/linux/rhashtable.h
View File

@@ -1268,8 +1268,9 @@ static inline int rhashtable_walk_init(struct rhashtable *ht,
* For a completely stable walk you should construct your own data * For a completely stable walk you should construct your own data
* structure outside the hash table. * structure outside the hash table.
* *
* This function may sleep so you must not call it from interrupt * This function may be called from any process context, including
* context or with spin locks held. * non-preemptable context, but cannot be called from softirq or
* hardirq context.
* *
* You must call rhashtable_walk_exit after this function returns. * You must call rhashtable_walk_exit after this function returns.
*/ */

5
lib/rhashtable.c
View File

@@ -668,8 +668,9 @@ EXPORT_SYMBOL_GPL(rhashtable_insert_slow);
* For a completely stable walk you should construct your own data * For a completely stable walk you should construct your own data
* structure outside the hash table. * structure outside the hash table.
* *
* This function may sleep so you must not call it from interrupt * This function may be called from any process context, including
* context or with spin locks held. * non-preemptable context, but cannot be called from softirq or
* hardirq context.
* *
* You must call rhashtable_walk_exit after this function returns. * You must call rhashtable_walk_exit after this function returns.
*/ */