leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

dm clone metadata: Fix return type of dm_clone_nr_of_hydrated_regions()

Browse Source 
dm_clone_nr_of_hydrated_regions() returns the number of regions that
have been hydrated so far. In order to do so it employs bitmap_weight().

Until now, the return type of dm_clone_nr_of_hydrated_regions() was
unsigned long.

Because bitmap_weight() returns an int, in case BITS_PER_LONG == 64 and
the return value of bitmap_weight() is 2^31 (the maximum allowed number
of regions for a device), the result is sign extended from 32 bits to 64
bits and an incorrect value is displayed, in the status output of
dm-clone, as the number of hydrated regions.

Fix this by having dm_clone_nr_of_hydrated_regions() return an unsigned
int.

Fixes: 7431b7835f ("dm: add clone target")
Cc: stable@vger.kernel.org # v5.4+
Signed-off-by: Nikos Tsironis <ntsironis@arrikto.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
This commit is contained in:
Nikos Tsironis 2020-03-27 16:01:11 +02:00 committed by Mike Snitzer
parent 9fc06ff568
commit 81d5553d12
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/md/dm-clone-metadata.c
View File

@ -656,7 +656,7 @@ bool dm_clone_is_range_hydrated(struct dm_clone_metadata *cmd,
return (bit >= (start + nr_regions)); return (bit >= (start + nr_regions));
} }
unsigned long dm_clone_nr_of_hydrated_regions(struct dm_clone_metadata *cmd) unsigned int dm_clone_nr_of_hydrated_regions(struct dm_clone_metadata *cmd)
{ {
return bitmap_weight(cmd->region_map, cmd->nr_regions); return bitmap_weight(cmd->region_map, cmd->nr_regions);
} }

2
drivers/md/dm-clone-metadata.h
View File

@ -156,7 +156,7 @@ bool dm_clone_is_range_hydrated(struct dm_clone_metadata *cmd,
/* /*
* Returns the number of hydrated regions. * Returns the number of hydrated regions.
*/ */
unsigned long dm_clone_nr_of_hydrated_regions(struct dm_clone_metadata *cmd); unsigned int dm_clone_nr_of_hydrated_regions(struct dm_clone_metadata *cmd);
/* /*
* Returns the first unhydrated region with region_nr >= @start * Returns the first unhydrated region with region_nr >= @start

2
drivers/md/dm-clone-target.c
View File

@ -1473,7 +1473,7 @@ static void clone_status(struct dm_target *ti, status_type_t type,
goto error; goto error;
} }
DMEMIT("%u %llu/%llu %llu %lu/%lu %u ", DMEMIT("%u %llu/%llu %llu %u/%lu %u ",
DM_CLONE_METADATA_BLOCK_SIZE, DM_CLONE_METADATA_BLOCK_SIZE,
(unsigned long long)(nr_metadata_blocks - nr_free_metadata_blocks), (unsigned long long)(nr_metadata_blocks - nr_free_metadata_blocks),
(unsigned long long)nr_metadata_blocks, (unsigned long long)nr_metadata_blocks,