leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ipv6: Remove some pointless conditionals before kfree_skb()

Browse Source 
Remove some pointless conditionals before kfree_skb().

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
expression E;
@@
- if (E)
- 	kfree_skb(E);
+ kfree_skb(E);
// </smpl>

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Wei Yongjun 2009-02-23 21:45:33 +00:00 committed by David S. Miller
parent 1ce85fe402
commit 800d55f146
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
net/ipv6/ipv6_sockglue.c
View File

@ -218,7 +218,6 @@ static int do_ipv6_setsockopt(struct sock *sk, int level, int optname,
if (opt) if (opt)
sock_kfree_s(sk, opt, opt->tot_len); sock_kfree_s(sk, opt, opt->tot_len);
pktopt = xchg(&np->pktoptions, NULL); pktopt = xchg(&np->pktoptions, NULL);
if (pktopt)
kfree_skb(pktopt); kfree_skb(pktopt);
sk->sk_destruct = inet_sock_destruct; sk->sk_destruct = inet_sock_destruct;

2
net/ipv6/tcp_ipv6.c
View File

@ -533,7 +533,6 @@ static inline void syn_flood_warning(struct sk_buff *skb)
static void tcp_v6_reqsk_destructor(struct request_sock *req) static void tcp_v6_reqsk_destructor(struct request_sock *req)
{ {
if (inet6_rsk(req)->pktopts)
kfree_skb(inet6_rsk(req)->pktopts); kfree_skb(inet6_rsk(req)->pktopts);
} }
@ -1611,7 +1610,6 @@ ipv6_pktoptions:
} }
} }
if (opt_skb)
kfree_skb(opt_skb); kfree_skb(opt_skb);
return 0; return 0;
} }