leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

iio: light: tsl2591: fix some signedness bugs

Browse Source 
These variables need to be int for the error handling to work.

Fixes: 2335f0d7c7 ("iio: light: Added AMS tsl2591 driver implementation")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YJ52r1XZ44myD9Xx@mwanda
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Dan Carpenter 2021-05-14 16:10:07 +03:00 committed by Jonathan Cameron
parent bd1455615f
commit 7fce54ace3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/iio/light/tsl2591.c
View File

@ -213,7 +213,7 @@ static int tsl2591_gain_to_multiplier(const u8 als_gain)
} }
} }
static u8 tsl2591_multiplier_to_gain(const u32 multiplier) static int tsl2591_multiplier_to_gain(const u32 multiplier)
{ {
switch (multiplier) { switch (multiplier) {
case TSL2591_CTRL_ALS_LOW_GAIN_MULTIPLIER: case TSL2591_CTRL_ALS_LOW_GAIN_MULTIPLIER:
@ -783,8 +783,8 @@ static int tsl2591_write_raw(struct iio_dev *indio_dev,
int val, int val2, long mask) int val, int val2, long mask)
{ {
struct tsl2591_chip *chip = iio_priv(indio_dev); struct tsl2591_chip *chip = iio_priv(indio_dev);
u32 int_time; int int_time;
u8 gain; int gain;
int ret; int ret;
mutex_lock(&chip->als_mutex); mutex_lock(&chip->als_mutex);